Create a pure v3 client #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Sep 16, 2024
Comment on lines
728
to
736
| val privateKeyBundle: PrivateKeyBundle | ||
| get() = PrivateKeyBundleBuilder.buildFromV1Key(privateKeyBundleV1) | ||
| get() = PrivateKeyBundleBuilder.buildFromV1Key(v1keys) | ||
|
|
||
| val v1keys: PrivateKeyBundleV1 | ||
| get() = privateKeyBundleV1 | ||
| get() = privateKeyBundleV1 ?: throw XMTPException("V2 only function") | ||
|
|
||
| val keys: PrivateKeyBundleV2 | ||
| get() = privateKeyBundleV1.toV2() | ||
| get() = v1keys.toV2() | ||
| } |
There was a problem hiding this comment.
logic all seems fine here, but these names seem very confusing for me personally. The names aren't new in this PR though, so no need to block the change.
an example improvement might be:
( we already have the nullable class field privateKeyBundleV1)
v1keyscould instead be called something likenonNullPrivateKeyBundleV1keyscould instead be calledprivateKeyBundleV2
There was a problem hiding this comment.
Ya this one really thew me off as well something I will be happy to kill with V2.
cameronvoell
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Changes all look good, just adding some ideas/nits related to code organization. I think the new client v3 constructor, and making privateKeyBundleV1 and apiClient both nullable is the right idea 👍
|
All tests pass 🎉 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly test 1to1 it would be nice to be able to create a pure v3 client. This will be necessary once we support SCW as well.